Changeset 1551 for trunk/pylucid/PyLucid/plugins_internal/plugin_admin/plugin_admin.py

Timestamp:

05/02/08 16:47:16 (23 months ago)

Author:

JensDiemer

Message:

update preferences:

• move the preferences form from the plugin module into the plugin config modul
• a plugin must not use try...except to get the preferences
• update all modules around the plugin install/deinstall etc.
• detect_page used the system_settings "index_page" value (setup a other default index page works!)

Files:

• trunk/pylucid/PyLucid/plugins_internal/plugin_admin/plugin_admin.py (modified) (5 diffs)

trunk/pylucid/PyLucid/plugins_internal/plugin_admin/plugin_admin.py

@@ -30 +30 @@
 
 from PyLucid.system.plugin_manager import get_plugin_list, install_plugin
-from PyLucid.system.plugin_import import get_plugin_config
+from PyLucid.system.plugin_import import get_plugin_config, get_plugin_version
 from PyLucid.system.BasePlugin import PyLucidBasePlugin
 from PyLucid.models import Plugin
@@ -134 +134 @@
                     continue
                 try:
-                    plugin_cfg = get_plugin_config(self.request,
-                        package_name, plugin_name, dissolve_version_string=True
+                    plugin_cfg = get_plugin_config(
+                        package_name, plugin_name, self.request.debug
                     )
                 except Exception, e:
@@ -142 +142 @@
                     self.page_msg("Error: %s" % e)
                 else:
+                    plugin_version = get_plugin_version(
+                        package_name, plugin_name, self.request.debug
+                    )
                     uninstalled_plugins.append({
                         "plugin_name": plugin_name,
@@ -148 +151 @@
                         "url": plugin_cfg.__url__,
                         "author": plugin_cfg.__author__,
-                        "version": plugin_cfg.__version__,
+                        "version": plugin_version,
                     })
 
@@ -165 +168 @@
         try:
             install_plugin(
-                self.request, package_name, plugin_name, active,
+                package_name, plugin_name, self.request.debug, active,
                 extra_verbose=False
             )