Changeset 1612 for trunk/pylucid/PyLucid/system/plugin_manager.py

Timestamp:

05/31/08 22:01:20 (22 months ago)

Author:

JensDiemer

Message:

• add a few test for the new plugin models
• unittest: test plugin would be copied to the normal plugins. So this plugin would be auto installed with all other plugins.
• Bugfix in lucidTag.py: 1 should not be converted to True ;)

Files:

• trunk/pylucid/PyLucid/system/plugin_manager.py (modified) (5 diffs)

trunk/pylucid/PyLucid/system/plugin_manager.py

@@ -30 +30 @@
 from django.db.models import Model
 from django.core.management.sql import sql_model_create, \
-                                                        sql_indexes_for_model, custom_sql_for_model
+                                    sql_indexes_for_model, custom_sql_for_model
 from django.http import HttpResponse, Http404
 
@@ -36 +36 @@
 from PyLucid.system.exceptions import *
 from PyLucid.system.plugin_import import get_plugin_module, \
-                                                                        get_plugin_config, get_plugin_version
-
-
+                                        get_plugin_config, get_plugin_version
 
 
@@ -53 +51 @@
         )
         request.page_msg(msg)
-        msg2 = '<i title="(Error details in page messages.)">["%s.%s" error.]</i>' % (
-            plugin_name, method_name
-        )
+        msg2 = (
+            '<i title="(Error details in page messages.)">["%s.%s" error.]</i>'
+        ) % (plugin_name, method_name)
         local_response.write(msg2)
 
@@ -198 +196 @@
 
 
-def get_create_table(models):
+def get_create_table(plugin_models):
     from django.core.management.color import no_style
     style = no_style()
 
     statements = []
-    for model in models:
+    for model in plugin_models:
         statements += sql_model_create(model, style)[0]
         statements += sql_indexes_for_model(model, style)
@@ -210 +208 @@
 
 
-
 def create_plugin_tables(plugin, extra_verbose):
-    plugin_module = get_plugin_module(
+    plugin_models = Plugin.objects.get_plugin_models(
         plugin.package_name,
         plugin.plugin_name,
         debug=extra_verbose,
     )
-    if not hasattr(plugin_module, "PLUGIN_MODELS"):
+    if not plugin_models:
         # Plugin has no models
-        if extra_verbose:
-            print "Info: No 'plugin_models' list defined, ok."
         return
-
-    plugin_models = plugin_module.PLUGIN_MODELS
 
     statements = get_create_table(plugin_models)
     cursor = connection.cursor()
     for statement in statements:
-        print repr(statement)
+        #print repr(statement)
         cursor.execute(statement)